Quantcast

<Swing Dev> RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

Muneer Kolarkunnu

Hi All,

 

Please review the following:

 

Bug : https://bugs.openjdk.java.net/browse/JDK-8172804

 

Webrev Link: http://cr.openjdk.java.net/~akolarkunnu/8172804/webrev.00/

 

Summary: This is a fix for a bug in Jemmy code, that we found while automating the SwingSet Demo.

Previously maximize() was implemented using Frame.setSize() which will set frame size as screen size, but its state is not changing, it will be Frame.NORMAL itself. 
Now it is implementing using, Frame.setExtendedState() with Frame.MAXIMIZED_BOTH as parameter, so that its actual state also will set to Frame.MAXIMIZED_BOTH. 

Also demaximize() is not implemented completely. So demaximize() is implementing using Frame.setExtendedState() with Frame.NORMAL .

 

Regards,

Muneer

 

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

Sergey Bylokhov
Looks fine.


Hi All,
 
Please review the following:
 
 
 
Summary: This is a fix for a bug in Jemmy code, that we found while automating the SwingSet Demo.
Previously maximize() was implemented using Frame.setSize() which will set frame size as screen size, but its state is not changing, it will be Frame.NORMAL itself. 
Now it is implementing using, Frame.setExtendedState() with Frame.MAXIMIZED_BOTH as parameter, so that its actual state also will set to Frame.MAXIMIZED_BOTH. 

Also demaximize() is not implemented completely. So demaximize() is implementing using Frame.setExtendedState() with Frame.NORMAL .
 
Regards,
Muneer

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

Alexandre (Shura) Iline
In reply to this post by Muneer Kolarkunnu
Looks good.
On Jan 16, 2017, at 5:39 AM, Muneer Kolarkunnu <[hidden email]> wrote:

Hi All,
 
Please review the following:
 
 
 
Summary: This is a fix for a bug in Jemmy code, that we found while automating the SwingSet Demo.
Previously maximize() was implemented using Frame.setSize() which will set frame size as screen size, but its state is not changing, it will be Frame.NORMAL itself. 
Now it is implementing using, Frame.setExtendedState() with Frame.MAXIMIZED_BOTH as parameter, so that its actual state also will set to Frame.MAXIMIZED_BOTH. 

Also demaximize() is not implemented completely. So demaximize() is implementing using Frame.setExtendedState() with Frame.NORMAL .
 
Regards,
Muneer

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

alexander.kouznetsov
In reply to this post by Muneer Kolarkunnu

Looks good to me.

Best regards,
Alexander Kouznetsov
On 1/16/2017 5:39 AM, Muneer Kolarkunnu wrote:

Hi All,

 

Please review the following:

 

Bug : https://bugs.openjdk.java.net/browse/JDK-8172804

 

Webrev Link: http://cr.openjdk.java.net/~akolarkunnu/8172804/webrev.00/

 

Summary: This is a fix for a bug in Jemmy code, that we found while automating the SwingSet Demo.

Previously maximize() was implemented using Frame.setSize() which will set frame size as screen size, but its state is not changing, it will be Frame.NORMAL itself. 
Now it is implementing using, Frame.setExtendedState() with Frame.MAXIMIZED_BOTH as parameter, so that its actual state also will set to Frame.MAXIMIZED_BOTH. 

Also demaximize() is not implemented completely. So demaximize() is implementing using Frame.setExtendedState() with Frame.NORMAL .

 

Regards,

Muneer

 


Loading...