<Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

K Suman Rajkumaar
Dear All,

Hi All, Could you please review this fix for JDK17?

Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.

Fix: Rewritten the above applet based test as a regular java test.

Best Regards,
K Suman Rajkumaar

-------------

Commit messages:
 - Removed white spaces
 - Rewritten the test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java as a regular java application.

Changes: https://git.openjdk.java.net/jdk/pull/2094/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2094&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259818
  Stats: 135 lines in 2 files changed: 77 ins; 37 del; 21 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2094.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2094/head:pull/2094

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Sergey Bylokhov-2
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar <[hidden email]> wrote:

> Dear All,
>
> Hi All, Could you please review this fix for JDK17?
>
> Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>
> Fix: Rewritten the above applet based test as a regular java test.
>
> Best Regards,
> K Suman Rajkumaar

test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java line 50:

> 48:  * @bug 8032667
> 49:  * @summary [macosx] Components cannot be rendered in HiDPI to BufferedImage
> 50:  * @run main bug8032667

I suggest do not convert manual tests from the applet to the regular tests, until we will not find a way to unify them, in a similar way as it was for "applet/manual=yesno". Otherwise, all our manual tests will look differently, since different people will make the UI differently.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Alexey Ivanov-2
On Sat, 16 Jan 2021 00:42:45 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> Dear All,
>>
>> Hi All, Could you please review this fix for JDK17?
>>
>> Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>>
>> Fix: Rewritten the above applet based test as a regular java test.
>>
>> Best Regards,
>> K Suman Rajkumaar
>
> test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java line 50:
>
>> 48:  * @bug 8032667
>> 49:  * @summary [macosx] Components cannot be rendered in HiDPI to BufferedImage
>> 50:  * @run main bug8032667
>
> I suggest do not convert manual tests from the applet to the regular tests, until we will not find a way to unify them, in a similar way as it was for "applet/manual=yesno". Otherwise, all our manual tests will look differently, since different people will make the UI differently.

Unifying the UI makes sense in the long run. Will it involve retrofitting all the existing manual test which already have its own UI?

In most cases, the UI in manual tests is similar: Pass / Fail buttons at the bottom with the test instructions above. Then there are differences… Other parts of the UI depend on the nature of the test.

I've always found manual tests a bit confusing: a test, especially applet-based one, opens two windows; however, one window is easier to focus on.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Alexey Ivanov-2
On Mon, 18 Jan 2021 11:30:55 GMT, Alexey Ivanov <[hidden email]> wrote:

>> test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java line 50:
>>
>>> 48:  * @bug 8032667
>>> 49:  * @summary [macosx] Components cannot be rendered in HiDPI to BufferedImage
>>> 50:  * @run main bug8032667
>>
>> I suggest do not convert manual tests from the applet to the regular tests, until we will not find a way to unify them, in a similar way as it was for "applet/manual=yesno". Otherwise, all our manual tests will look differently, since different people will make the UI differently.
>
> Unifying the UI makes sense in the long run. Will it involve retrofitting all the existing manual test which already have its own UI?
>
> In most cases, the UI in manual tests is similar: Pass / Fail buttons at the bottom with the test instructions above. Then there are differences… Other parts of the UI depend on the nature of the test.
>
> I've always found manual tests a bit confusing: a test, especially applet-based one, opens two windows; however, one window is easier to focus on.

To confirm: we're not modifying the current applet-based manual tests until there's a common framework to migrate them off the applet API. Do I understand it correctly?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Sergey Bylokhov-2
On Mon, 18 Jan 2021 12:12:10 GMT, Alexey Ivanov <[hidden email]> wrote:

>> Unifying the UI makes sense in the long run. Will it involve retrofitting all the existing manual test which already have its own UI?
>>
>> In most cases, the UI in manual tests is similar: Pass / Fail buttons at the bottom with the test instructions above. Then there are differences… Other parts of the UI depend on the nature of the test.
>>
>> I've always found manual tests a bit confusing: a test, especially applet-based one, opens two windows; however, one window is easier to focus on.
>
> To confirm: we're not modifying the current applet-based manual tests until there's a common framework to migrate them off the applet API. Do I understand it correctly?

Yes, I suggest that. Maybe we can start with that replacement? In the jtreg itself or via separate lib.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Alexey Ivanov-2
On Mon, 18 Jan 2021 12:28:07 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> To confirm: we're not modifying the current applet-based manual tests until there's a common framework to migrate them off the applet API. Do I understand it correctly?
>
> Yes, I suggest that. Maybe we can start with that replacement? In the jtreg itself or via separate lib.

A separate lib seems more convenient as it will allow running such tests without test harness which is quicker and useful for debugging.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

Phil Race
In reply to this post by K Suman Rajkumaar
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar <[hidden email]> wrote:

> Dear All,
>
> Hi All, Could you please review this fix for JDK17?
>
> Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>
> Fix: Rewritten the above applet based test as a regular java test.
>
> Best Regards,
> K Suman Rajkumaar

If this PR isn't going to be approved, can it please be withdrawn ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Withdrawn: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

K Suman Rajkumaar
In reply to this post by K Suman Rajkumaar
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar <[hidden email]> wrote:

> Dear All,
>
> Hi All, Could you please review this fix for JDK17?
>
> Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>
> Fix: Rewritten the above applet based test as a regular java test.
>
> Best Regards,
> K Suman Rajkumaar

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

K Suman Rajkumaar
In reply to this post by Phil Race
On Wed, 10 Feb 2021 17:58:45 GMT, Phil Race <[hidden email]> wrote:

>> Dear All,
>>
>> Hi All, Could you please review this fix for JDK17?
>>
>> Problem Description: The test open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>>
>> Fix: Rewritten the above applet based test as a regular java test.
>>
>> Best Regards,
>> K Suman Rajkumaar
>
> If this PR isn't going to be approved, can it please be withdrawn ?

Closing this PR as there's going to be a new common framework to migrate manual tests in the coming days.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2094