<Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

amresh-sahu
Added @build org.jemmy2ext.JemmyExt.

-------------

Commit messages:
 - JDK-8263235:Added @build org.jemmy2ext.JemmyExt
 - Merge pull request #2 from openjdk/master

Changes: https://git.openjdk.java.net/jdk/pull/2958/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2958&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263235
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2958.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2958/head:pull/2958

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

amresh-sahu
On Fri, 12 Mar 2021 05:29:01 GMT, Amresh Sahu <[hidden email]> wrote:

> Added @build org.jemmy2ext.JemmyExt.

@shurymury , @akolarkunnu
Kindly review my changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

Abdul Kolarkunnu
On Fri, 12 Mar 2021 05:40:35 GMT, Amresh Sahu <[hidden email]> wrote:

>> Added @build org.jemmy2ext.JemmyExt.
>
> @shurymury , @akolarkunnu
> Kindly review my changes.

looks good to me

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

Prasanta Sadhukhan-2
In reply to this post by amresh-sahu
On Fri, 12 Mar 2021 05:29:01 GMT, Amresh Sahu <[hidden email]> wrote:

> Added @build org.jemmy2ext.JemmyExt.

test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java line 66:

> 64: *          java.logging
> 65: * @build org.jemmy2ext.JemmyExt
> 66: * @build com.sun.swingset3.demos.colorchooser.ColorChooserDemo

I guess you also need to update GridBagLayoutDemoTest.java with the same.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError [v2]

amresh-sahu
In reply to this post by amresh-sahu
> Added @build org.jemmy2ext.JemmyExt.

Amresh Sahu has updated the pull request incrementally with one additional commit since the last revision:

  JDK-8263235:Added @build org.jemmy2ext.JemmyExt

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2958/files
  - new: https://git.openjdk.java.net/jdk/pull/2958/files/ce31d169..6673b53b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2958&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2958&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2958.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2958/head:pull/2958

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError [v2]

Prasanta Sadhukhan-2
On Fri, 12 Mar 2021 14:39:23 GMT, Amresh Sahu <[hidden email]> wrote:

>> Added @build org.jemmy2ext.JemmyExt.
>
> Amresh Sahu has updated the pull request incrementally with one additional commit since the last revision:
>
>   JDK-8263235:Added @build org.jemmy2ext.JemmyExt

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError [v2]

Sergey Bylokhov-2
In reply to this post by amresh-sahu
On Fri, 12 Mar 2021 14:39:23 GMT, Amresh Sahu <[hidden email]> wrote:

>> Added @build org.jemmy2ext.JemmyExt.
>
> Amresh Sahu has updated the pull request incrementally with one additional commit since the last revision:
>
>   JDK-8263235:Added @build org.jemmy2ext.JemmyExt

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: JDK-8263235 : sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

amresh-sahu
In reply to this post by amresh-sahu
On Fri, 12 Mar 2021 05:29:01 GMT, Amresh Sahu <[hidden email]> wrote:

> Added @build org.jemmy2ext.JemmyExt.

This pull request has now been integrated.

Changeset: cb70ab0c
Author:    Your Name <[hidden email]>
Committer: Sergey Bylokhov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/cb70ab0c
Stats:     2 lines in 2 files changed: 2 ins; 0 del; 0 mod

8263235: sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError

Reviewed-by: psadhukhan, serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/2958