[patch] change gcjwebplugin description

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] change gcjwebplugin description

Matthias Klose-6
The plugin name used for IcedTea is the same as the one from classpath, but
shows up with the same name in the browser; could we rename it to better
identify the jvm? Name suggested by Michael Koch, now GCJ stands for "Great Cool
Java".

  Matthias


2007-10-15  Matthias Klose <[hidden email]>

        * gcjwebplugin.cc: Change PLUGIN_NAME.

diff -r f9b8887af3ab gcjwebplugin.cc
--- a/gcjwebplugin.cc Fri Oct 12 12:26:19 2007 -0400
+++ b/gcjwebplugin.cc Mon Oct 15 14:13:34 2007 +0200
@@ -83,7 +83,7 @@ exception statement from your version. *
               __LINE__, g_thread_self (), first, second, third)
 
 // Plugin information passed to about:plugins.
-#define PLUGIN_NAME "GCJ Web Browser Plugin"
+#define PLUGIN_NAME "GCJ Web Browser Plugin (using IcedTea)"
 #define PLUGIN_DESC "The " PLUGIN_NAME " executes Java applets."
 #define PLUGIN_MIME_DESC                                               \
   "application/x-java-vm:class,jar:IcedTea;"                           \
Reply | Threaded
Open this post in threaded view
|

Re: [patch] change gcjwebplugin description

Lillian Angel
I committed your patch.

Thanks,
Lillian

Matthias Klose wrote:
> The plugin name used for IcedTea is the same as the one from classpath, but
> shows up with the same name in the browser; could we rename it to better
> identify the jvm? Name suggested by Michael Koch, now GCJ stands for "Great Cool
> Java".
>
>   Matthias
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [patch] change gcjwebplugin description

Matthew Flaschen
In reply to this post by Matthias Klose-6
Matthias Klose wrote:
> The plugin name used for IcedTea is the same as the one from classpath, but
> shows up with the same name in the browser; could we rename it to better
> identify the jvm?

This should really be in icedtea-plugin.patch .  Patch to repository
attached.

Matt Flaschen

diff -r 72f6e91f1ec5 patches/icedtea-plugin.patch
--- a/patches/icedtea-plugin.patch Mon Oct 15 16:24:31 2007 -0400
+++ b/patches/icedtea-plugin.patch Tue Oct 16 03:47:08 2007 -0400
@@ -1281,3 +1281,14 @@ diff -urN openjdk.orig/j2se/src/share/cl
 + return message;
 +    }
 +}
+--- gcjwebplugin.orig   2007-10-16 03:15:38.000000000 -0400
++++ gcjwebplugin.cc     2007-10-16 03:17:04.000000000 -0400
+@@ -83,7 +83,7 @@
+               __LINE__, g_thread_self (), first, second, third)
+
+ // Plugin information passed to about:plugins.
+-#define PLUGIN_NAME "GCJ Web Browser Plugin"
++#define PLUGIN_NAME "GCJ Web Browser Plugin (using IcedTea)"
+ #define PLUGIN_DESC "The " PLUGIN_NAME " executes Java applets."
+ #define PLUGIN_MIME_DESC                                               \
+   "application/x-java-vm:class,jar:IcedTea;"                           \
Reply | Threaded
Open this post in threaded view
|

Re: [patch] change gcjwebplugin description

Lillian Angel
Matthew Flaschen wrote:

> Matthias Klose wrote:
>  
>> The plugin name used for IcedTea is the same as the one from classpath, but
>> shows up with the same name in the browser; could we rename it to better
>> identify the jvm?
>>    
>
> This should really be in icedtea-plugin.patch .  Patch to repository
> attached.
>  

No, the patches in patches/ are for openjdk. gcjwebplugin.cc is our
source and not from the OpenJDK zip.

Lillian