(trivial) RFR: 8190881: [TESTBUG] test.runtime.ErrorHandling.TestOnError comment is incomplete

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

(trivial) RFR: 8190881: [TESTBUG] test.runtime.ErrorHandling.TestOnError comment is incomplete

David Holmes
Bug: https://bugs.openjdk.java.net/browse/JDK-8190881

Can a Reviewer please spare me 5 seconds to okay this totally trivial
deletion of a partial comment.

Thanks,
David

diff -r 2cd7d700217f
test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
--- a/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
+++ b/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -44,7 +44,6 @@

          String msg = "Test Succeeded";

-        // Execute the VM so that a
          ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
             "-XX:-TransmitErrorReport",
             "-XX:-CreateCoredumpOnCrash",

Reply | Threaded
Open this post in threaded view
|

Re: (trivial) RFR: 8190881: [TESTBUG] test.runtime.ErrorHandling.TestOnError comment is incomplete

Igor Ignatyev
looks good to me.

-- Igor

> On Nov 8, 2017, at 9:38 PM, David Holmes <[hidden email]> wrote:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190881
>
> Can a Reviewer please spare me 5 seconds to okay this totally trivial deletion of a partial comment.
>
> Thanks,
> David
>
> diff -r 2cd7d700217f test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
> --- a/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
> +++ b/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -44,7 +44,6 @@
>
>         String msg = "Test Succeeded";
>
> -        // Execute the VM so that a
>         ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
>            "-XX:-TransmitErrorReport",
>            "-XX:-CreateCoredumpOnCrash",
>

Reply | Threaded
Open this post in threaded view
|

Re: (trivial) RFR: 8190881: [TESTBUG] test.runtime.ErrorHandling.TestOnError comment is incomplete

David Holmes
Thanks Igor!

David

On 9/11/2017 3:41 PM, Igor Ignatyev wrote:

> looks good to me.
>
> -- Igor
>> On Nov 8, 2017, at 9:38 PM, David Holmes <[hidden email]> wrote:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8190881
>>
>> Can a Reviewer please spare me 5 seconds to okay this totally trivial deletion of a partial comment.
>>
>> Thanks,
>> David
>>
>> diff -r 2cd7d700217f test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
>> --- a/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
>> +++ b/test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -44,7 +44,6 @@
>>
>>          String msg = "Test Succeeded";
>>
>> -        // Execute the VM so that a
>>          ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
>>             "-XX:-TransmitErrorReport",
>>             "-XX:-CreateCoredumpOnCrash",
>>
>