[urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

Erik Joelsson
In the change for JDK-8189094 I accidentally broke testing in Mach 5.
The problem is in jib-profiles.js where the definition of boot_jdk_home
is no longer defined globally in the common object, and because of this,
JT_JAVA does not get a good value in the run-test* profiles.

This patch restores common.boot_jdk_home and common.boot_jdk_version.
Testing is under way.

Webrev: http://cr.openjdk.java.net/~erikj/8189679/webrev.01/

Bug: https://bugs.openjdk.java.net/browse/JDK-8189679

/Erik

Reply | Threaded
Open this post in threaded view
|

Re: [urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

Tim Bell
Erik:

> In the change for JDK-8189094 I accidentally broke testing in Mach 5.
> The problem is in jib-profiles.js where the definition of boot_jdk_home
> is no longer defined globally in the common object, and because of this,
> JT_JAVA does not get a good value in the run-test* profiles.
>
> This patch restores common.boot_jdk_home and common.boot_jdk_version.
> Testing is under way.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8189679/webrev.01/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189679

Looks good to me.

/Tim


Reply | Threaded
Open this post in threaded view
|

Re: [urgent] RFR: JDK-8189679: JDK-8189094 broke testing in Mach 5

Mandy Chung
In reply to this post by Erik Joelsson
Looks good.

Mandy

On 10/19/17 8:29 AM, Erik Joelsson wrote:

> In the change for JDK-8189094 I accidentally broke testing in Mach 5.
> The problem is in jib-profiles.js where the definition of
> boot_jdk_home is no longer defined globally in the common object, and
> because of this, JT_JAVA does not get a good value in the run-test*
> profiles.
>
> This patch restores common.boot_jdk_home and common.boot_jdk_version.
> Testing is under way.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8189679/webrev.01/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189679
>
> /Erik
>